Bug 144159 - [Cocoa] Remove users of FontPlatformData's CGFontRef constructor
Summary: [Cocoa] Remove users of FontPlatformData's CGFontRef constructor
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-24 13:50 PDT by Myles C. Maxfield
Modified: 2015-04-24 20:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.06 KB, patch)
2015-04-24 13:54 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (759.30 KB, application/zip)
2015-04-24 14:42 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (709.37 KB, application/zip)
2015-04-24 14:58 PDT, Build Bot 		no flags Details
WIP (6.29 KB, patch)
2015-04-24 20:43 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-04-24 13:50:23 PDT 
[Cocoa] Remove users of FontPlatformData's CGFontRef constructor
Comment 1 Myles C. Maxfield 2015-04-24 13:54:59 PDT 
Created attachment 251569 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-24 14:28:51 PDT 
Users of cgFont():

showGlyphsWithAdvances() in FontCascadeCocoa.mm uses it for CGContextShowGlyphsAtPositions() and CGContextShowGlyphsWithAdvances(). CoreText replacement is CTFontDrawGlyphs().

Font::platformWidthForGlyph() uses it for CGFontGetGlyphAdvancesForStyle(). CoreText replacement is CTFontGetAdvancesForGlyphs().

GlyphPage::fill() uses it for CGFontGetGlyphsForUnichars(). CoreText replacement is CTFontGetGlyphsForCharacters() and CTFontGetVerticalGlyphsForCharacters().
Comment 3 Build Bot 2015-04-24 14:42:28 PDT 
Comment on attachment 251569 [details]
Patch

Attachment 251569 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6271638072983552

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2015-04-24 14:42:31 PDT 
Created attachment 251575 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-04-24 14:58:24 PDT 
Comment on attachment 251569 [details]
Patch

Attachment 251569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5446593109032960

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2015-04-24 14:58:26 PDT 
Created attachment 251578 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Myles C. Maxfield 2015-04-24 20:43:00 PDT 
Created attachment 251607 [details]
WIP
Comment 8 Myles C. Maxfield 2015-04-24 20:43:33 PDT 
Comment on attachment 251607 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=251607&action=review

> Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:43
> +    CGFloat size = 16;

This has got to go.