Bug 144150 - REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
Summary: REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-24 09:36 PDT by Timothy Hatcher
Modified: 2015-04-24 11:45 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2015-04-24 09:39 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-24 09:36:45 PDT 
There are two issues with this one in WebKit2 and one in InspectorFrontendAPI.js.
Comment 1 Radar WebKit Bug Importer 2015-04-24 09:37:05 PDT 
<rdar://problem/20685861>
Comment 2 Timothy Hatcher 2015-04-24 09:39:40 PDT 
Created attachment 251555 [details]
Patch
Comment 3 Brian Burg 2015-04-24 10:16:02 PDT 
Comment on attachment 251555 [details]
Patch

r=me

It would be great to simplify this code a little, some day.
Comment 4 WebKit Commit Bot 2015-04-24 11:03:42 PDT 
Comment on attachment 251555 [details]
Patch

Clearing flags on attachment: 251555

Committed r183268: <http://trac.webkit.org/changeset/183268>
Comment 5 WebKit Commit Bot 2015-04-24 11:03:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2015-04-24 11:45:14 PDT 
Comment on attachment 251555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251555&action=review

> Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:259
> +    evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])"));

The ASCIILiteral is not needed here now that we are using makeString(...).