Bug 144149 - [Mac] Hit testing on <embed> PDFs not working properly
Summary: [Mac] Hit testing on <embed> PDFs not working properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 143952
Blocks:
  Show dependency tree / graph
 
Reported: 2015-04-24 08:41 PDT by Brent Fulgham
Modified: 2015-04-24 14:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.60 KB, patch)
2015-04-24 13:57 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-04-24 08:41:14 PDT 
Testing has shown that there is a hit testing bug for embedded (<embed>) PDF's. Full page PDFs (at any scale) do work properly.

This can be seen in the TestWebKitAPI 'ActionMenuTest' suite.
Comment 1 Brent Fulgham 2015-04-24 11:06:36 PDT 
<rdar://problem/20677770>
Comment 2 Brent Fulgham 2015-04-24 11:08:09 PDT 
There was an error in the recent PDF positioning calculations I made. I have a local fix, but it is based on the code in Bug 143952.
Comment 3 Brent Fulgham 2015-04-24 13:57:21 PDT 
Created attachment 251570 [details]
Patch
Comment 4 WebKit Commit Bot 2015-04-24 13:59:19 PDT 
Attachment 251570 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:738:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2015-04-24 14:54:54 PDT 
Committed r183282: <http://trac.webkit.org/changeset/183282>