Bug 144144 - [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
Summary: [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency treegraph
 
Reported: 2015-04-24 02:49 PDT by Manuel Rego Casasnovas
Modified: 2015-04-26 22:41 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.27 KB, patch)
2015-04-24 02:59 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2015-04-24 02:49:00 PDT
Per spec (http://dev.w3.org/csswg/css-sizing-3/#definite):
"Additionally, the size of the containing block of an absolutely  positioned element is always definite with respect to that element."

If height is auto, we're ignoring this condition. Related Blink issue (where this was detected on flexbox first): https://codereview.chromium.org/1081433005/
Comment 1 Manuel Rego Casasnovas 2015-04-24 02:59:52 PDT
Created attachment 251545 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-26 22:41:09 PDT
Comment on attachment 251545 [details]
Patch

Clearing flags on attachment: 251545

Committed r183385: <http://trac.webkit.org/changeset/183385>
Comment 3 WebKit Commit Bot 2015-04-26 22:41:14 PDT
All reviewed patches have been landed.  Closing bug.