RESOLVED FIXED 144129
[iOS] Add a wrapper around the hosted AVPlayerLayer to intercept -setBounds: 
https://bugs.webkit.org/show_bug.cgi?id=144129
Summary [iOS] Add a wrapper around the hosted AVPlayerLayer to intercept -setBounds:
Jer Noble
Reported 2015-04-23 15:24:36 PDT
[iOS] Add a wrapper around the hosted AVPlayerLayer to intercept -setBounds:
Attachments
Patch (7.92 KB, patch)
2015-04-23 15:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2015-04-23 15:57 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (9.37 KB, patch)
2015-04-23 15:59 PDT, Jer Noble 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-04-23 15:48:29 PDT
Created attachment 251502 [details] Patch
Jer Noble
Comment 2 2015-04-23 15:49:29 PDT
<rdar://problem/18683624>
Jer Noble
Comment 3 2015-04-23 15:57:15 PDT
Created attachment 251505 [details] Patch
Jer Noble
Comment 4 2015-04-23 15:59:31 PDT
Created attachment 251506 [details] Patch
Simon Fraser (smfr)
Comment 5 2015-04-23 16:07:26 PDT
Comment on attachment 251506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251506&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:592 > + [super setBounds:bounds]; > + This should probably early-return when the bounds aren't changing. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:612 > + FloatRect videoFrame = self.model->videoLayerFrame(); > + FloatRect targetFrame; > + switch (self.model->videoLayerGravity()) { > + case WebCore::WebVideoFullscreenModel::VideoGravityResize: > + targetFrame = bounds; > + break; > + case WebCore::WebVideoFullscreenModel::VideoGravityResizeAspect: > + targetFrame = largestRectWithAspectRatioInsideRect(videoFrame.size().aspectRatio(), bounds); > + break; > + case WebCore::WebVideoFullscreenModel::VideoGravityResizeAspectFill: > + targetFrame = smallestRectWithAspectRatioAroundRect(videoFrame.size().aspectRatio(), bounds); > + break; > + } > + CATransform3D transform = CATransform3DMakeScale(targetFrame.width() / videoFrame.width(), targetFrame.height() / videoFrame.height(), 1); > + [_videoSublayer setSublayerTransform:transform]; Doing all this inside -setBounds makes me slightly nervous, but it's probably OK. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:615 > + [self performSelector:@selector(resolveBounds) withObject:nil afterDelay:[CATransaction animationDuration] + 0.1]; Add a comment to explain the magic + 0.1?
Jer Noble
Comment 6 2015-04-23 16:44:33 PDT
Committed r183229: <http://trac.webkit.org/changeset/183229>
Note You need to log in before you can comment on or make changes to this bug.