Bug 144122 – Update media timeline controls when video is paused.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

We don't show or update our controls when the video is paused.
This is normally not an issue if you pause via the controls because the timeline is already active and being shown but if paused programmatically, (like when the video ends) the controls do not appear.

[Roger Fong]

rdar://problem/19823121

[Roger Fong]

Note that this now matches our behavior on iOS.

[Roger Fong]

Created attachment 251493 [details]
patchh

[Jon Lee]

Comment on attachment 251493 [details]
patchh

View in context: https://bugs.webkit.org/attachment.cgi?id=251493&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310
> +            this.showControls();

This will keep the controls hidden if the <video> does not specify the "controls" attribute?

[Roger Fong]

(In reply to comment #4)
> Comment on attachment 251493 [details]
> patchh
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251493&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310
> > +            this.showControls();
> 
> This will keep the controls hidden if the <video> does not specify the
> "controls" attribute?

The controls won't be created at all if the we don't specify the controls attribute, (at least they don't show up in the shadow DOM, so they could be getting display: none'd).
Either this won't effect the "controls" attribute.

[WebKit Commit Bot]

Comment on attachment 251493 [details]
patchh

Clearing flags on attachment: 251493

Committed r183225: <http://trac.webkit.org/changeset/183225>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.