Bug 144122 - Update media timeline controls when video is paused.
Summary: Update media timeline controls when video is paused.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-23 14:40 PDT by Roger Fong
Modified: 2015-04-23 16:02 PDT (History)
3 users (show)

See Also:


Attachments
patchh (2.44 KB, patch)
2015-04-23 14:45 PDT, Roger Fong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-23 14:40:24 PDT
We don't show or update our controls when the video is paused.
This is normally not an issue if you pause via the controls because the timeline is already active and being shown but if paused programmatically, (like when the video ends) the controls do not appear.
Comment 1 Roger Fong 2015-04-23 14:40:56 PDT
rdar://problem/19823121
Comment 2 Roger Fong 2015-04-23 14:42:49 PDT
Note that this now matches our behavior on iOS.
Comment 3 Roger Fong 2015-04-23 14:45:11 PDT
Created attachment 251493 [details]
patchh
Comment 4 Jon Lee 2015-04-23 14:48:11 PDT
Comment on attachment 251493 [details]
patchh

View in context: https://bugs.webkit.org/attachment.cgi?id=251493&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310
> +            this.showControls();

This will keep the controls hidden if the <video> does not specify the "controls" attribute?
Comment 5 Roger Fong 2015-04-23 15:21:30 PDT
(In reply to comment #4)
> Comment on attachment 251493 [details]
> patchh
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251493&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1310
> > +            this.showControls();
> 
> This will keep the controls hidden if the <video> does not specify the
> "controls" attribute?

The controls won't be created at all if the we don't specify the controls attribute, (at least they don't show up in the shadow DOM, so they could be getting display: none'd).
Either this won't effect the "controls" attribute.
Comment 6 WebKit Commit Bot 2015-04-23 16:02:40 PDT
Comment on attachment 251493 [details]
patchh

Clearing flags on attachment: 251493

Committed r183225: <http://trac.webkit.org/changeset/183225>
Comment 7 WebKit Commit Bot 2015-04-23 16:02:44 PDT
All reviewed patches have been landed.  Closing bug.