Move content view showing out of ResourceSidebarPanel and make it global and know how to show tabs.
Created attachment 251464 [details] Patch
Comment on attachment 251464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251464&action=review r=me! Nice > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:28 > - constructor() > + constructor(contentBrowser) The call to "new WebInspector.DebuggerSidebarPanel" should pass the contentBrowser. I assume that should be in Main.js and was just missed in this patch. > Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:193 > showDefaultContentView() > { > - WebInspector.resourceSidebarPanel.showDefaultContentView(); > + var currentTreeElement = this._contentTreeOutline.children[0]; > + while (currentTreeElement && !currentTreeElement.root) { > + if (currentTreeElement instanceof WebInspector.ResourceTreeElement || currentTreeElement instanceof WebInspector.ScriptTreeElement) { > + currentTreeElement.revealAndSelect(); > + return; > + } > + > + currentTreeElement = currentTreeElement.traverseNextTreeElement(false, null, true); > + } > } What should this show in the case that there is no tree element? Maybe then blank is fine, but perhaps it would be nice to have something. E.g. a JSContext inspector with no scripts.
Comment on attachment 251464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251464&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:28 >> + constructor(contentBrowser) > > The call to "new WebInspector.DebuggerSidebarPanel" should pass the contentBrowser. I assume that should be in Main.js and was just missed in this patch. It is in DebuggerTabContentView. I added it locally but it wasn't in this patch. My patch sets are bleeding together in spots like this. >> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:193 >> } > > What should this show in the case that there is no tree element? Maybe then blank is fine, but perhaps it would be nice to have something. > > E.g. a JSContext inspector with no scripts. I think blank is fine for now.
r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342