Bug 144106 - [GTK] Make all options actually options
Summary: [GTK] Make all options actually options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on: 144105
Blocks: 143546
  Show dependency tree / graph
 
Reported: 2015-04-23 10:21 PDT by Michael Catanzaro
Modified: 2015-04-28 11:03 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.68 KB, patch)
2015-04-28 08:59 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-23 10:21:14 PDT 
We have several options in PlatformGTK.cmake that are not actually options right now:

set(ENABLE_GTKDOC OFF CACHE BOOL "Whether or not to use generate gtkdoc.")
set(ENABLE_X11_TARGET ON CACHE BOOL "Whether to enable support for the X11 windowing target.")
set(ENABLE_WAYLAND_TARGET OFF CACHE BOOL "Whether to enable support for the Wayland windowing target.")
set(ENABLE_INTROSPECTION ON CACHE BOOL "Whether to enable GObject introspection.")
set(ENABLE_GLES2 OFF CACHE BOOL "Whether to enable OpenGL ES 2.0.")

These should all be defined with WEBKIT_OPTION_DEFINE so that they are printed in the features list.
Comment 1 Michael Catanzaro 2015-04-28 08:57:32 PDT 
Turns out this is really easy now that bug #144105 is closed.
Comment 2 Michael Catanzaro 2015-04-28 08:59:33 PDT 
Created attachment 251849 [details]
Patch
Comment 3 Michael Catanzaro 2015-04-28 09:02:49 PDT 
Martin: another quick review here would be dandy.

After this, only bug #143546 is left!
Comment 4 Michael Catanzaro 2015-04-28 11:03:11 PDT 
Comment on attachment 251849 [details]
Patch

Clearing flags on attachment: 251849

Committed r183491: <http://trac.webkit.org/changeset/183491>
Comment 5 Michael Catanzaro 2015-04-28 11:03:16 PDT 
All reviewed patches have been landed.  Closing bug.