Bug 144102 - [GTK] Fixups for ENABLE_CREDENTIAL_STORAGE
Summary: [GTK] Fixups for ENABLE_CREDENTIAL_STORAGE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-23 09:26 PDT by Michael Catanzaro
Modified: 2015-04-23 10:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2015-04-23 09:28 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-23 09:26:03 PDT 
ENABLE_CREDENTIAL_STORAGE became a WebKit option in r182996 so we shouldn't set it manually anymore. Also, if ENABLE_CREDENTIAL_STORAGE is set but libsecret is not present, the build needs to fail. (We can consider giving it a nicer error message in bug #143546.)
Comment 1 Michael Catanzaro 2015-04-23 09:28:49 PDT 
Created attachment 251447 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-23 10:30:43 PDT 
Comment on attachment 251447 [details]
Patch

Clearing flags on attachment: 251447

Committed r183192: <http://trac.webkit.org/changeset/183192>
Comment 3 WebKit Commit Bot 2015-04-23 10:30:46 PDT 
All reviewed patches have been landed.  Closing bug.