[EFL] Build failure, linker does not find libXext.

[Doug Newgard]

Currently the build process fails for me in Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp because of the call to XSetExtensionErrorHandler. The problem is in Source/WebKit2/PlatformEfl.cmake, currently lines 342-350:

if (ENABLE_ECORE_X)
    list(APPEND WebProcess_LIBRARIES
        ${ECORE_X_LIBRARIES}
        ${X11_Xext_LIB}
    )
    list(APPEND WebKit2_LIBRARIES
        ${ECORE_X_LIBRARIES}
    )
endif ()

The Xext libraries get added to WebProcess_LIBRARIES, but the source file is in WebKit2_SOURCES (line 212). Either WebProcessMainEfl needs to be in WebProcess_SOURCES or the Xext libraries need to be added to WebKit2_LIBRARIES.

[Hyungwook Lee]

Created attachment 253424 [details]
patch

[Gyuyoung Kim]

One question, I wonder if we need to keep ${X11_Xext_LIB} in WebProcess_LIBRARIES.


if (ENABLE_ECORE_X)
    list(APPEND WebProcess_LIBRARIES
        ${ECORE_X_LIBRARIES}
        ${X11_Xext_LIB}

endif ()

[Hyungwook Lee]

WebProcessMainEfl.cpp is listed in WebKit2_SOURCES.
So I think we need to put X11_Xext_LIB into WebKit2_LIBRARIES to fix "undefined reference to 'XSetExtensionErrorHandler'" linking error.

We need to move WebProcessMainEfl.cpp from WebKit2_SOURCES list to WebProcess_SOURCES list if we want to keep X11_Xext_LIB in WebProcess_LIBRARIES.

I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks better.

[Gyuyoung Kim]

(In reply to comment #3)

> I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks
> better.

I agree with it. As you know, *WebKit2_SOURCES* was originated only for WebProcess executable file as our MiniBrowser executable. So when WebProcessMainEfl.cpp is only used for WebProcess executable, I also think we can move it to WebProcess_SOURCES.

If we don't need to keep to ${X11_Xext_LIB} in WebProcess_LIBRARIES anymore, let's remove it there. Do you agree ?


if (ENABLE_ECORE_X)
    list(APPEND WebProcess_LIBRARIES
        ${ECORE_X_LIBRARIES}
        ${X11_Xext_LIB}

endif ()

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #3)
> 
> > I think to keep WebProcessMainEfl.cpp in WebKit2_SOURCES list is looks
> > better.
> 
> I agree with it. As you know, *WebKit2_SOURCES* was originated only for
> WebProcess executable file as our MiniBrowser executable.

s/WebKit2_SOURCES/WebProcess_SOURCES/g

[Hyungwook Lee]

Created attachment 253435 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 253435 [details]
Patch

Thanks Hyungwook !

[WebKit Commit Bot]

Comment on attachment 253435 [details]
Patch

Clearing flags on attachment: 253435

Committed r184632: <http://trac.webkit.org/changeset/184632>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.