Bug 144094 - [cmake] Fix generate-js-builtins related incremental build issue
Summary: [cmake] Fix generate-js-builtins related incremental build issue
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Reported: 2015-04-23 03:37 PDT by Csaba Osztrogonác
Modified: 2015-05-04 01:23 PDT (History)
6 users (show)

See Also:

Patch (4.62 KB, patch)
2015-04-23 03:52 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-04-23 03:37:42 PDT
See https://bugs.webkit.org/show_bug.cgi?id=143980#c14 for details.

The root of the problem that cmake finds the input of generate-js-builtins
with *.js search. But the make/ninja doesn't know when the input list should
be regenerated and adding a new js can cause incremantal build fail.

I think we should teach generate-js-builtins to accept not only js files
as input, but an input directory where it can collects all of the js files
and we will be able remove *.js from cmake build system.
Comment 1 Csaba Osztrogonác 2015-04-23 03:52:28 PDT
Created attachment 251426 [details]
Comment 2 Csaba Osztrogonác 2015-04-23 04:03:10 PDT
cc-ed Oliver and Michael as the original author and reviewer of
the generate-js-builtins script - http://trac.webkit.org/changeset/163195

I added the new --input-directory option to be able get rid of *.js
from cmake and let the python script to collect js files. But I didn't
remove the actual behaviour of the script, maybe somebody wants to
generate builtins for a couple of js not for all js in a directory.

Do you think if this change is acceptable to 
avoid incremental build issues in the future?
Comment 3 Csaba Osztrogonác 2015-04-28 03:53:56 PDT
Comment 4 Michael Saboff 2015-04-28 10:19:48 PDT
Comment on attachment 251426 [details]

Comment 5 Csaba Osztrogonác 2015-05-04 01:23:41 PDT
Comment on attachment 251426 [details]

Clearing flags on attachment: 251426

Committed r183738: <http://trac.webkit.org/changeset/183738>
Comment 6 Csaba Osztrogonác 2015-05-04 01:23:48 PDT
All reviewed patches have been landed.  Closing bug.