See https://bugs.webkit.org/show_bug.cgi?id=143980#c14 for details. The root of the problem that cmake finds the input of generate-js-builtins with *.js search. But the make/ninja doesn't know when the input list should be regenerated and adding a new js can cause incremantal build fail. I think we should teach generate-js-builtins to accept not only js files as input, but an input directory where it can collects all of the js files and we will be able remove *.js from cmake build system.
Created attachment 251426 [details] Patch
cc-ed Oliver and Michael as the original author and reviewer of the generate-js-builtins script - http://trac.webkit.org/changeset/163195 I added the new --input-directory option to be able get rid of *.js from cmake and let the python script to collect js files. But I didn't remove the actual behaviour of the script, maybe somebody wants to generate builtins for a couple of js not for all js in a directory. Do you think if this change is acceptable to avoid incremental build issues in the future?
ping?
Comment on attachment 251426 [details] Patch r=me
Comment on attachment 251426 [details] Patch Clearing flags on attachment: 251426 Committed r183738: <http://trac.webkit.org/changeset/183738>
All reviewed patches have been landed. Closing bug.