Bug 14409 - Double click on a resource in the sidebar should open that resource in Safari
Summary: Double click on a resource in the sidebar should open that resource in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2007-06-26 05:33 PDT by Timothy Hatcher
Modified: 2009-07-24 01:21 PDT (History)
3 users (show)

See Also:

Attachments
Double Click opens the Resource in a New Window (1.25 KB, patch)
2009-07-17 22:02 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2007-06-26 05:33:07 PDT 
A double click on a resource in the sidebar should open that resource directly in a new Safari window.
Comment 1 Adam Roben (:aroben) 2008-01-29 11:01:22 PST 
<rdar://problem/5712835>
Comment 2 Joseph Pecoraro 2009-07-17 22:02:27 PDT 
Created attachment 33006 [details]
Double Click opens the Resource in a New Window

Side effect of a really good design is that a feature like this requires a couple lines of code.  This opens up a new window with the url of the resource.

NOTES:
- Should we white-list file extensions or mime-types?
- Is this behavior still desired? (I think its fine).
Comment 3 Joseph Pecoraro 2009-07-17 22:14:14 PDT 
Actually, now that I think about it.  "window.open" can be redefined by the inspected page.  So if that cannot be "trusted" then we would have to resort to something else.  Thoughts?
Comment 4 Adam Barth 2009-07-24 01:21:23 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ResourcesPanel.js
Committed r46336
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ResourcesPanel.js
r46336 = 3a3566570220a9ffc5cd2bdb9f43ddf2c6d164ca (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46336