Bug 144089 - [WK2] WebDiagnosticLoggingClient is leaking
Summary: [WK2] WebDiagnosticLoggingClient is leaking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-22 22:36 PDT by Chris Dumez
Modified: 2015-04-23 01:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.04 KB, patch)
2015-04-22 23:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-04-22 22:36:15 PDT 
WebDiagnosticLoggingClient is leaking. It is constructed inside the WebPage constructor but there is no code destroying it.
We should add a new xxxDestroyed() virtual function that calls "delete this" in WebDiagnosticLoggingClient, similarly to what is done for other WK2 clients.

Radar: <rdar://problem/19706214>
Comment 1 Chris Dumez 2015-04-22 23:18:15 PDT 
Created attachment 251410 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-23 01:13:40 PDT 
Comment on attachment 251410 [details]
Patch

Clearing flags on attachment: 251410

Committed r183179: <http://trac.webkit.org/changeset/183179>
Comment 3 WebKit Commit Bot 2015-04-23 01:13:45 PDT 
All reviewed patches have been landed.  Closing bug.