Bug 144083 - [EFL] Build failure to find gio-unix
Summary: [EFL] Build failure to find gio-unix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 18:09 PDT by Doug Newgard
Modified: 2015-04-29 07:36 PDT (History)
4 users (show)

See Also:

Attachments
Move geoclue block before find_package(GLIB...) (1.11 KB, patch)
2015-04-22 18:09 PDT, Doug Newgard 		no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2015-04-29 04:52 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Newgard 2015-04-22 18:09:19 PDT 
Created attachment 251392 [details]
Move geoclue block before find_package(GLIB...)

Currently the gio-unix headers do not get included, leading to a build failure when building geoclue support. Patch attached fixes it.
Comment 1 Ryuan Choi 2015-04-28 18:08:27 PDT 
Can you update the patch with ChangeLog?

You should touch ChangeLog in root directory.
http://www.webkit.org/coding/contributing.html
Comment 2 Doug Newgard 2015-04-28 19:06:05 PDT 
Unfortunately, not very well. The scripts you pointed me to aren't running for me. The repo layout is kind of ridiculous, so I only have a partial checkouts.
Comment 3 Ryuan Choi 2015-04-29 04:52:08 PDT 
Created attachment 251945 [details]
Patch
Comment 4 Ryuan Choi 2015-04-29 04:52:53 PDT 
(In reply to comment #2)
> Unfortunately, not very well. The scripts you pointed me to aren't running
> for me. The repo layout is kind of ridiculous, so I only have a partial
> checkouts.

OK, I uploaded the patch with changelog instead of you.
Comment 5 Gyuyoung Kim 2015-04-29 05:23:45 PDT 
Comment on attachment 251945 [details]
Patch

Thank you for fixing.
Comment 6 WebKit Commit Bot 2015-04-29 07:36:10 PDT 
Comment on attachment 251945 [details]
Patch

Clearing flags on attachment: 251945

Committed r183545: <http://trac.webkit.org/changeset/183545>
Comment 7 WebKit Commit Bot 2015-04-29 07:36:16 PDT 
All reviewed patches have been landed.  Closing bug.