WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
144081
There should only be one way to get the system memory size.
https://bugs.webkit.org/show_bug.cgi?id=144081
Summary
There should only be one way to get the system memory size.
Andreas Kling
Reported
2015-04-22 17:22:28 PDT
This is currently implemented in different ways in different files. Let's put something in WTF that everyone can use.
Attachments
Patch
(17.42 KB, patch)
2015-04-22 23:23 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
Patch
(17.55 KB, patch)
2015-04-23 00:08 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2015-04-22 17:30:02 PDT
Tim pointed out that WTF already has ramSize(). So let's try using that everywhere!
Andreas Kling
Comment 2
2015-04-22 23:23:53 PDT
Created
attachment 251411
[details]
Patch
WebKit Commit Bot
Comment 3
2015-04-22 23:25:15 PDT
Attachment 251411
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/RAMSize.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/RAMSize.cpp:91: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:54: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 4
2015-04-23 00:08:39 PDT
Created
attachment 251413
[details]
Patch
WebKit Commit Bot
Comment 5
2015-04-23 00:10:59 PDT
Attachment 251413
[details]
did not pass style-queue: ERROR: Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:54: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 6
2015-04-23 01:23:28 PDT
Committed
r183181
: <
http://trac.webkit.org/changeset/183181
>
Brent Fulgham
Comment 7
2015-04-23 08:39:47 PDT
This seems to be creating a build failure: /Volumes/Data/slave/yosemite-release/build/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:58:9: fatal error: 'wtf/RamSize.h' file not found
Alexey Proskuryakov
Comment 8
2015-04-23 09:10:18 PDT
Started fixing the build in <
http://trac.webkit.org/r183188
>. There may be more...
Alexey Proskuryakov
Comment 9
2015-04-23 09:58:15 PDT
Andy Estes pointed out that the WTF part of the fix was not necessary. Rolled it out in
r183190
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug