Bug 144079 – Provide a runtime flag to run-webkit-tests that shows the test view

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brent Fulgham]

I find it helpful when debugging tests to be able to see the WebView as the test runs. We should provide a runtime flag so that instead of rendering off screen we can display the view.

This should be available for:
1. DumpRenderTree
2. WebKitTestRunner
3. TestWebKitAPI

[Brent Fulgham]

Skipping TestWebKitAPI for now, since it doesn't process its own arguments (it's all driven by the Google test infrastructure.

[Brent Fulgham]

Since this is only needed for debugging while creating tests, we will invoke it via the "--additional-drt-flag" option:

--additional-drt-flag="--show-webview"

[Brent Fulgham]

Created attachment 252078 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 252078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252078&action=review

> Tools/WebKitTestRunner/Options.cpp:115
> +    if (option[0] && option[1] && option[0] == '-' && option[1] == '-')
> +        return true;

Why this bit? It's different from how handleOptionRemoteLayerTree works.

> Tools/WebKitTestRunner/TestInvocation.cpp:180
> +    WKRetainPtr<WKStringRef> shouldShowWebViewKey(AdoptWK, WKStringCreateWithUTF8CString("ShouldShowWebView"));
> +    WKRetainPtr<WKBooleanRef> shouldShowWebViewValue = adoptWK(WKBooleanCreate(TestController::singleton().shouldShowWebView()));
> +    WKDictionarySetItem(beginTestMessageBody.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get());

I don't get why these have to go to the injected bundle. We create the view in the UI process.

[Brent Fulgham]

Created attachment 252095 [details]
Patch

[Brent Fulgham]

(In reply to comment #4)
> Comment on attachment 252078 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=252078&action=review
> 
> > Tools/WebKitTestRunner/Options.cpp:115
> > +    if (option[0] && option[1] && option[0] == '-' && option[1] == '-')
> > +        return true;
> 
> Why this bit? It's different from how handleOptionRemoteLayerTree works.

OK -- I fixed it to be consistent with "--remote-layer-tree".

> > Tools/WebKitTestRunner/TestInvocation.cpp:180
> > +    WKRetainPtr<WKStringRef> shouldShowWebViewKey(AdoptWK, WKStringCreateWithUTF8CString("ShouldShowWebView"));
> > +    WKRetainPtr<WKBooleanRef> shouldShowWebViewValue = adoptWK(WKBooleanCreate(TestController::singleton().shouldShowWebView()));
> > +    WKDictionarySetItem(beginTestMessageBody.get(), shouldShowWebViewKey.get(), shouldShowWebViewValue.get());
> 
> I don't get why these have to go to the injected bundle. We create the view
> in the UI process.

I was just blindly following the "timeout" option. We don't need this for the InjectedBundle. I'll remove it.

[Brent Fulgham]

Committed r183651: <http://trac.webkit.org/changeset/183651>

[Brent Fulgham]

Follow-up correction landed in r183765:
Committed r183765: <http://trac.webkit.org/changeset/183765>