Bug 144076 - [iOS] Caret does not line up with text when using the system font
Summary: [iOS] Caret does not line up with text when using the system font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-22 16:04 PDT by Myles C. Maxfield
Modified: 2015-04-22 16:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.75 KB, patch)
2015-04-22 16:11 PDT, Myles C. Maxfield
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-04-22 16:04:40 PDT
[iOS] Caret does not line up with text when using the system font
Comment 1 Myles C. Maxfield 2015-04-22 16:11:36 PDT
Created attachment 251379 [details]
Patch
Comment 2 Enrica Casucci 2015-04-22 16:15:33 PDT
Comment on attachment 251379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251379&action=review

Looks good.

> Source/WebCore/ChangeLog:10
> +        the complext text codepath must know about custom tracking.

typo complex

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:55
> +        CFDictionarySetValue(mutableAttributes, kCTFontAttributeName, platformData().ctFont());

I would change this code to
CFDictionarySetValue(mutableAttributes, kCTFontAttributeName, hasCustomTracking() ? platformData().font() : platformData().ctFont());
Comment 3 Myles C. Maxfield 2015-04-22 16:23:58 PDT
Committed r183153: <http://trac.webkit.org/changeset/183153>