Bug 144072 – Volume slider appears/doesn't appear at the wrong times

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Roger Fong]

rdar://problem/20576145

2 things here:
a) set pointer-events: none of background divs for volume slider so the box doesn't appear randomly
b) call drawVolumeBackground on the over event for the mute box.

[Roger Fong]

Created attachment 251375 [details]
patch

[Roger Fong]

Note that the slider drew for <video> elements before because we drew it as a result of calling showControls().

However, we don't call showControls() for <audio> elements because the controls are always visible anyways.

[Dean Jackson]

Comment on attachment 251375 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251375&action=review

> Source/WebCore/ChangeLog:12
> +        Don't allow mouse interaction with the background divs.
> +        * Modules/mediacontrols/mediaControlsApple.css:
> +        (audio::-webkit-media-controls-volume-slider-container-background):
> +        (audio::-webkit-media-controls-volume-slider-container-tint):

I'm not sure why you needed to do this. As long as the backgrounds are behind the controls, wouldn't the control get the event?

[Roger Fong]

(In reply to comment #3)
> Comment on attachment 251375 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251375&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        Don't allow mouse interaction with the background divs.
> > +        * Modules/mediacontrols/mediaControlsApple.css:
> > +        (audio::-webkit-media-controls-volume-slider-container-background):
> > +        (audio::-webkit-media-controls-volume-slider-container-tint):
> 
> I'm not sure why you needed to do this. As long as the backgrounds are
> behind the controls, wouldn't the control get the event?

In this situation, when the volume box is hidden, the controls have a width of 0, so the background, while hidden, are above the controls.

Maybe a better way to do this is to make the widths of the background divs 0 as well while hidden.

[Roger Fong]

http://trac.webkit.org/changeset/183168