Bug 144063 - Web Inspector: Remove time and weight from the dashboard
Summary: Web Inspector: Remove time and weight from the dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-04-22 12:11 PDT by Timothy Hatcher
Modified: 2015-04-25 18:36 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.45 KB, patch)
2015-04-22 12:13 PDT, Timothy Hatcher
joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-04-22 12:11:04 PDT
These two items were the odd men out since they are only available when recording a timeline. We will need the toolbar space soon, so make this lets us make the dashboard skinnier.
Comment 1 Timothy Hatcher 2015-04-22 12:13:04 PDT
Created attachment 251354 [details]
Patch
Comment 2 Timothy Hatcher 2015-04-22 12:43:19 PDT
Comment on attachment 251354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251354&action=review

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js:143
> +        console.assert(contentView, "Unknown representedObject", representedObject);
> +        if (!contentView)

I fixed this locally. It should be dashboardView, not contentView.
Comment 3 Joseph Pecoraro 2015-04-22 13:09:33 PDT
Comment on attachment 251354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251354&action=review

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-40
> -                tooltip: WebInspector.UIString("Total size of all resources, click to show the Network Requests timeline"),

Be sure to update localized strings as well.

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-41
> -                handler: this._networkItemWasClicked

These are the only callers of "this._networkItemWasClicked" so you should remove that as well.

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-76
> -        var timeItem = this._items.time;
> -        timeItem.text = dashboard.time ? Number.secondsToString(dashboard.time) : "\u2014";
> -        this._setItemEnabled(timeItem, dashboard.time > 0);

This removes what I think are the only users of "dashboard.time" and "dashboard.resourcesSize". Should we then also remove these properties, and management, from the WebInspector.DefaultDashboard Model object?
Comment 4 Timothy Hatcher 2015-04-25 18:36:12 PDT
r183322r183342

http://trac.webkit.org/log/?revs=183322-183342