Bug 144063 – Web Inspector: Remove time and weight from the dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

These two items were the odd men out since they are only available when recording a timeline. We will need the toolbar space soon, so make this lets us make the dashboard skinnier.

[Timothy Hatcher]

Created attachment 251354 [details]
Patch

[Timothy Hatcher]

Comment on attachment 251354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251354&action=review

> Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js:143
> +        console.assert(contentView, "Unknown representedObject", representedObject);
> +        if (!contentView)

I fixed this locally. It should be dashboardView, not contentView.

[Joseph Pecoraro]

Comment on attachment 251354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251354&action=review

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-40
> -                tooltip: WebInspector.UIString("Total size of all resources, click to show the Network Requests timeline"),

Be sure to update localized strings as well.

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-41
> -                handler: this._networkItemWasClicked

These are the only callers of "this._networkItemWasClicked" so you should remove that as well.

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:-76
> -        var timeItem = this._items.time;
> -        timeItem.text = dashboard.time ? Number.secondsToString(dashboard.time) : "\u2014";
> -        this._setItemEnabled(timeItem, dashboard.time > 0);

This removes what I think are the only users of "dashboard.time" and "dashboard.resourcesSize". Should we then also remove these properties, and management, from the WebInspector.DefaultDashboard Model object?

[Timothy Hatcher]

r183322 – r183342

http://trac.webkit.org/log/?revs=183322-183342