Bug 144059 - [CMake] Use lowercase for local variables in macros
Summary: [CMake] Use lowercase for local variables in macros
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Trivial
Assignee: Michael Catanzaro
Depends on: 144060
  Show dependency treegraph
Reported: 2015-04-22 11:48 PDT by Michael Catanzaro
Modified: 2015-04-22 12:02 PDT (History)
2 users (show)

See Also:

Patch (2.94 KB, patch)
2015-04-22 11:50 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-04-22 11:48:17 PDT
Requested by Martin Robinson, we should use lowercase for local variables inside macros in WebKitFeatures.cmake, as we do in WebKitMacros.cmake.
Comment 1 Michael Catanzaro 2015-04-22 11:50:06 PDT
Created attachment 251347 [details]
Comment 2 Martin Robinson 2015-04-22 11:51:24 PDT
Comment on attachment 251347 [details]

Thanks for the cleanup!
Comment 3 Michael Catanzaro 2015-04-22 11:53:19 PDT
Committed r183116: <http://trac.webkit.org/changeset/183116>
Comment 4 WebKit Commit Bot 2015-04-22 11:59:01 PDT
Re-opened since this is blocked by bug 144060
Comment 5 Michael Catanzaro 2015-04-22 12:02:44 PDT
Comment on attachment 251347 [details]

Clearing flags on attachment: 251347

Committed r183120: <http://trac.webkit.org/changeset/183120>
Comment 6 Michael Catanzaro 2015-04-22 12:02:48 PDT
All reviewed patches have been landed.  Closing bug.