This is needed to pass TimelineSidebarPanel to the Timeline views.
Created attachment 251343 [details] Patch
Comment on attachment 251343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Suport passing extra arguments to ContentViews during construction Typo: "Suport" => "Support" > Source/WebInspectorUI/UserInterface/Views/ContentView.js:34 > - return new WebInspector.FrameContentView(representedObject); > + return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments); Related intentional change? This would break some code inside FrameContentView without a related change, since it does: if (this.representedObject.isMainFrame()) Which doesn't make sense on the mainResource.
Comment on attachment 251343 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review >> Source/WebInspectorUI/UserInterface/Views/ContentView.js:34 >> + return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments); > > Related intentional change? This would break some code inside FrameContentView without a related change, since it does: > > if (this.representedObject.isMainFrame()) > > Which doesn't make sense on the mainResource. Bad reverse merge on my part. In my tree the end result is: return new WebInspector.ResourceClusterContentView(representedObject.mainResource, extraArguments); FrameContentView will be going away.
r183322 – r183342 http://trac.webkit.org/log/?revs=183322-183342