Bug 144055 – Web Inspector: Support passing extra arguments to ContentViews during construction

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

This is needed to pass TimelineSidebarPanel to the Timeline views.

[Timothy Hatcher]

Created attachment 251343 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 251343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: Suport passing extra arguments to ContentViews during construction

Typo: "Suport" => "Support"

> Source/WebInspectorUI/UserInterface/Views/ContentView.js:34
> -            return new WebInspector.FrameContentView(representedObject);
> +            return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments);

Related intentional change? This would break some code inside FrameContentView without a related change, since it does:

    if (this.representedObject.isMainFrame())

Which doesn't make sense on the mainResource.

[Timothy Hatcher]

Comment on attachment 251343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251343&action=review

>> Source/WebInspectorUI/UserInterface/Views/ContentView.js:34
>> +            return new WebInspector.FrameContentView(representedObject.mainResource, extraArguments);
> 
> Related intentional change? This would break some code inside FrameContentView without a related change, since it does:
> 
>     if (this.representedObject.isMainFrame())
> 
> Which doesn't make sense on the mainResource.

Bad reverse merge on my part.

In my tree the end result is:

            return new WebInspector.ResourceClusterContentView(representedObject.mainResource, extraArguments);

FrameContentView will be going away.

[Timothy Hatcher]

r183322 – r183342

http://trac.webkit.org/log/?revs=183322-183342