Bug 144029 - Web Inspector: Vertically misaligned text in Object Trees
Summary: Web Inspector: Vertically misaligned text in Object Trees
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jonathan Wells
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-21 18:57 PDT by Joseph Pecoraro
Modified: 2015-04-26 06:02 PDT (History)
8 users (show)

See Also:

Attachments
[IMAGE] Issue (56.96 KB, image/png)
2015-04-21 18:57 PDT, Joseph Pecoraro 		no flags Details
[PATCH] alignment fix. (1.54 KB, patch)
2015-04-25 23:49 PDT, Jonathan Wells 		no flags Details | Formatted Diff | Diff
[IMAGE] Fix. (144.83 KB, image/png)
2015-04-25 23:51 PDT, Jonathan Wells 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-21 18:57:48 PDT 
Created attachment 251290 [details]
[IMAGE] Issue

* SUMMARY
Vertically misaligned text in Object Trees. Seen in Yosemite, see attached image.

* STEPS TO REPRODUCE
1. js> window.navigator
2. Expand object tree
  => Fonts look misaligned, especially in the "Prototype" button

* NOTES
- This regressed with bug 143909 / r182982 which switched us to use -webkit-system-font in more places over sans-serif.
Comment 1 Radar WebKit Bug Importer 2015-04-21 18:58:18 PDT 
<rdar://problem/20645270>
Comment 2 Joseph Pecoraro 2015-04-21 19:12:55 PDT 
We may just be able to remove the "top:2px" from ".object-tree-property > .titles" in ObjectTreePropertyTreeElement.css.
Comment 3 Timothy Hatcher 2015-04-21 20:13:02 PDT 
I see a shift in the object name when expanding "▶︎ Object" to "▼ Object". Same thing?
Comment 4 Jonathan Wells 2015-04-25 22:53:41 PDT 
(In reply to comment #2)
> We may just be able to remove the "top:2px" from ".object-tree-property >
> .titles" in ObjectTreePropertyTreeElement.css.

top:1px seems to look the best. I'll post a screen.
Comment 5 Jonathan Wells 2015-04-25 23:42:19 PDT 
(In reply to comment #4)
> (In reply to comment #2)
> > We may just be able to remove the "top:2px" from ".object-tree-property >
> > .titles" in ObjectTreePropertyTreeElement.css.
> 
> top:1px seems to look the best. I'll post a screen.

You were right, Joe. Removing "top:2px" is correct.
Comment 6 Jonathan Wells 2015-04-25 23:49:49 PDT 
Created attachment 251677 [details]
[PATCH] alignment fix.
Comment 7 Jonathan Wells 2015-04-25 23:51:09 PDT 
Created attachment 251678 [details]
[IMAGE] Fix.
Comment 8 WebKit Commit Bot 2015-04-26 06:02:10 PDT 
Comment on attachment 251677 [details]
[PATCH] alignment fix.

Clearing flags on attachment: 251677

Committed r183352: <http://trac.webkit.org/changeset/183352>
Comment 9 WebKit Commit Bot 2015-04-26 06:02:22 PDT 
All reviewed patches have been landed.  Closing bug.