Bug 144017 - Long pause under _takeViewSnapshot when screen updates are disabled
Summary: Long pause under _takeViewSnapshot when screen updates are disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-21 15:25 PDT by Tim Horton
Modified: 2015-04-21 16:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2015-04-21 15:26 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-04-21 15:25:18 PDT 
Long pause under _takeViewSnapshot when screen updates are disabled
Comment 1 Tim Horton 2015-04-21 15:26:13 PDT 
Created attachment 251268 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-21 15:29:16 PDT 
Attachment 251268 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:122:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:123:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "cid" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "windowCount" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:177:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-04-21 16:26:23 PDT 
http://trac.webkit.org/changeset/183083