Bug 144003 - Get rid of an unneeded function from LoaderNSURLExtras.mm
Summary: Get rid of an unneeded function from LoaderNSURLExtras.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-21 12:50 PDT by Anders Carlsson
Modified: 2015-04-21 13:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2015-04-21 12:51 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2015-04-21 13:31 PDT, Anders Carlsson 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-04-21 12:50:55 PDT 
Get rid of an unneeded function from LoaderNSURLExtras.mm
Comment 1 Anders Carlsson 2015-04-21 12:51:23 PDT 
Created attachment 251257 [details]
Patch
Comment 2 Chris Dumez 2015-04-21 13:28:24 PDT 
Does not build?

/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:904:19: error: use of overloaded operator '==' is ambiguous (with operand types 'const WTF::String' and 'NSString *const')
        if (at(i) == value)
            ~~~~~ ^  ~~~~~
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Vector.h:896:12: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::find<NSString *>' requested here
    return find(value) != notFound;
           ^
/Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:77:49: note: in instantiation of function template specialization 'WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow>::contains<NSString *>' requested here
        if (extensions.isEmpty() || !extensions.contains(extension)) {
                                                ^
In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/loader/mac/LoaderNSURLExtras.mm:35:
In file included from /Volumes/Data/EWS/WebKit/Source/WebCore/platform/URL.h:32:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/text/WTFString.h:484:13: note: candidate function
inline bool operator==(const String& a, const String& b) { return equal(a.impl(), b.impl()); }
Comment 3 Anders Carlsson 2015-04-21 13:31:12 PDT 
Created attachment 251259 [details]
Patch
Comment 4 Chris Dumez 2015-04-21 13:32:25 PDT 
Comment on attachment 251259 [details]
Patch

r=me
Comment 5 Anders Carlsson 2015-04-21 13:33:54 PDT 
Committed r183074: <http://trac.webkit.org/changeset/183074>