Bug 143984 - Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()
Summary: Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-21 02:16 PDT by Manuel Rego Casasnovas
Modified: 2015-04-22 03:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.71 KB, patch)
2015-04-21 02:23 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch for landing (12.36 KB, patch)
2015-04-22 02:02 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2015-04-21 02:16:44 PDT 
Rename hasOverride{Height,Width}() to hasOverrideLogicalContent{Height,Width}()
Comment 1 Manuel Rego Casasnovas 2015-04-21 02:23:04 PDT 
Created attachment 251225 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2015-04-21 03:10:17 PDT 
Adding some reviewers on CC, this is a simple refactoring.
Comment 3 Darin Adler 2015-04-21 08:49:47 PDT 
Comment on attachment 251225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251225&action=review

> Source/WebCore/WebCore.order:6853
> -__ZNK7WebCore9RenderBox17hasOverrideHeightEv
> +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv

No need to ever hand-edit order files; they have to be regenerated by actually running tests with WebKit. If editing this file was needed, this is wrong because the 17 is no longer correct.
Comment 4 Manuel Rego Casasnovas 2015-04-22 02:02:23 PDT 
Created attachment 251307 [details]
Patch for landing
Comment 5 Manuel Rego Casasnovas 2015-04-22 02:03:38 PDT 
Thanks for the review!

(In reply to comment #3)
> Comment on attachment 251225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=251225&action=review
> 
> > Source/WebCore/WebCore.order:6853
> > -__ZNK7WebCore9RenderBox17hasOverrideHeightEv
> > +__ZNK7WebCore9RenderBox17hasOverrideLogicalContentHeightEv
> 
> No need to ever hand-edit order files; they have to be regenerated by
> actually running tests with WebKit. If editing this file was needed, this is
> wrong because the 17 is no longer correct.

Yeah, it was manually modified. I only checked that the Mac build worked after the modification, but it also works without any change, so I'm removing this change.
Comment 6 WebKit Commit Bot 2015-04-22 03:32:33 PDT 
Comment on attachment 251307 [details]
Patch for landing

Clearing flags on attachment: 251307

Committed r183100: <http://trac.webkit.org/changeset/183100>
Comment 7 WebKit Commit Bot 2015-04-22 03:32:39 PDT 
All reviewed patches have been landed.  Closing bug.