RESOLVED FIXED 143981
[GTK] jhbuild should not use a branch for openwebrtc 
https://bugs.webkit.org/show_bug.cgi?id=143981
Summary [GTK] jhbuild should not use a branch for openwebrtc
Carlos Garcia Campos
Reported 2015-04-21 00:36:30 PDT
It basically means that any commit in that branch can break our build, like it has happened now, see https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/57664/steps/jhbuild/logs/stdio We should use a tag or a particular revision, never a branch, and this applies to any other module.
Attachments
patch (2.47 KB, patch)
2015-04-21 00:52 PDT, Philippe Normand 		cgarcia: review+
DetailsFormatted DiffDiff
patch for landing (2.49 KB, patch)
2015-04-21 01:07 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
patch (1.40 KB, patch)
2015-04-21 01:14 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2015-04-21 00:52:16 PDT
Created attachment 251222 [details] patch
Carlos Garcia Campos
Comment 2 2015-04-21 00:58:16 PDT
Comment on attachment 251222 [details] patch Thanks, I'm assuming the EFL change is correct, please wait for EWS just in case
Philippe Normand
Comment 3 2015-04-21 01:07:15 PDT
Created attachment 251223 [details] patch for landing
Philippe Normand
Comment 4 2015-04-21 01:14:02 PDT
Created attachment 251224 [details] patch
WebKit Commit Bot
Comment 5 2015-04-21 02:58:45 PDT
Comment on attachment 251224 [details] patch Clearing flags on attachment: 251224 Committed r183060: <http://trac.webkit.org/changeset/183060>
WebKit Commit Bot
Comment 6 2015-04-21 02:58:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.