Bug 143981 - [GTK] jhbuild should not use a branch for openwebrtc
Summary: [GTK] jhbuild should not use a branch for openwebrtc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2015-04-21 00:36 PDT by Carlos Garcia Campos
Modified: 2015-04-21 02:58 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.47 KB, patch)
2015-04-21 00:52 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
patch for landing (2.49 KB, patch)
2015-04-21 01:07 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
patch (1.40 KB, patch)
2015-04-21 01:14 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-04-21 00:36:30 PDT 
It basically means that any commit in that branch can break our build, like it has happened now, see https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/57664/steps/jhbuild/logs/stdio

We should use a tag or a particular revision, never a branch, and this applies to any other module.
Comment 1 Philippe Normand 2015-04-21 00:52:16 PDT 
Created attachment 251222 [details]
patch
Comment 2 Carlos Garcia Campos 2015-04-21 00:58:16 PDT 
Comment on attachment 251222 [details]
patch

Thanks, I'm assuming the EFL change is correct, please wait for EWS just in case
Comment 3 Philippe Normand 2015-04-21 01:07:15 PDT 
Created attachment 251223 [details]
patch for landing
Comment 4 Philippe Normand 2015-04-21 01:14:02 PDT 
Created attachment 251224 [details]
patch
Comment 5 WebKit Commit Bot 2015-04-21 02:58:45 PDT 
Comment on attachment 251224 [details]
patch

Clearing flags on attachment: 251224

Committed r183060: <http://trac.webkit.org/changeset/183060>
Comment 6 WebKit Commit Bot 2015-04-21 02:58:48 PDT 
All reviewed patches have been landed.  Closing bug.