Bug 143978 - Don't bother storing to Node::m_refCount when it hits zero.
Summary: Don't bother storing to Node::m_refCount when it hits zero.
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-20 19:49 PDT by Andreas Kling
Modified: 2023-09-09 02:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.57 KB, patch)
2015-04-20 20:01 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-mavericks (528.39 KB, application/zip)
2015-04-20 20:47 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (568.88 KB, application/zip)
2015-04-20 21:17 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-04-20 19:49:34 PDT 
Let's do it like RefCounted.
Comment 1 Andreas Kling 2015-04-20 20:01:22 PDT 
Created attachment 251213 [details]
Patch
Comment 2 Build Bot 2015-04-20 20:47:43 PDT 
Comment on attachment 251213 [details]
Patch

Attachment 251213 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6234700280496128

New failing tests:
editing/selection/leak-document-with-selection-inside.html
Comment 3 Build Bot 2015-04-20 20:47:46 PDT 
Created attachment 251214 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-04-20 21:17:31 PDT 
Comment on attachment 251213 [details]
Patch

Attachment 251213 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5942429702160384

New failing tests:
editing/selection/leak-document-with-selection-inside.html
Comment 5 Build Bot 2015-04-20 21:17:34 PDT 
Created attachment 251215 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Darin Adler 2015-04-21 09:12:32 PDT 
What’s the deal with that test failure?
Comment 7 Ahmad Saleem 2023-09-08 15:58:27 PDT 
@Ryosuke - do we need this now?
Comment 8 Ryosuke Niwa 2023-09-09 02:27:09 PDT 
We've done this.