Bug 143969 - Web Inspector: Unify PrettyPrinting Tool and UserInterface resources
Summary: Web Inspector: Unify PrettyPrinting Tool and UserInterface resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-20 15:37 PDT by Joseph Pecoraro
Modified: 2015-04-20 21:36 PDT (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.70 KB, patch)
2015-04-20 15:38 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (391.45 KB, patch)
2015-04-20 16:14 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (408.14 KB, patch)
2015-04-20 16:16 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-04-20 15:37:05 PDT
* SUMMARY
Unify PrettyPrinting and UserInterface resources.

Step 1, update them so they are equivalent.
Step 2, remove the script and just have the PrettyPrinting Tool use UserInterface resources.

These fixes are the "misc" changes from Bug 141692 by Tobias Reiss.
Comment 1 Radar WebKit Bug Importer 2015-04-20 15:37:26 PDT
<rdar://problem/20624619>
Comment 2 Joseph Pecoraro 2015-04-20 15:38:52 PDT
Created attachment 251194 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2015-04-20 16:08:40 PDT
Comment on attachment 251194 [details]
[PATCH] Proposed Fix

Never mind this, I'm just going to do everything all at once, since it is rather easy.
Comment 4 Joseph Pecoraro 2015-04-20 16:14:20 PDT
Created attachment 251198 [details]
[PATCH] Proposed Fix
Comment 5 Joseph Pecoraro 2015-04-20 16:16:34 PDT
Created attachment 251200 [details]
[PATCH] Proposed Fix
Comment 6 Timothy Hatcher 2015-04-20 20:46:55 PDT
Comment on attachment 251200 [details]
[PATCH] Proposed Fix

Good call.
Comment 7 WebKit Commit Bot 2015-04-20 21:36:52 PDT
Comment on attachment 251200 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 251200

Committed r183043: <http://trac.webkit.org/changeset/183043>
Comment 8 WebKit Commit Bot 2015-04-20 21:36:56 PDT
All reviewed patches have been landed.  Closing bug.