Bug 143959 – Add a bool parameter to decidePolicyForNavigationAction and decidePolicyForNewWindowAction in WKPagePolicyClient to track whether it's user initiated

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit2

[Ada Chan]

These are the new definitions of the decidePolicyForNavigationAction and decidePolicyForNewWindowAction callbacks:

typedef void (*WKPageDecidePolicyForNavigationActionCallback)(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool isUserInitiated, WKFrameRef originatingFrame, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo);
typedef void (*WKPageDecidePolicyForNewWindowActionCallback)(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool isUserInitiated, WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo);

This is needed for <rdar://problem/20139052>

(In reply to Ada Chan from comment #0)
> These are the new definitions of the decidePolicyForNavigationAction and
> decidePolicyForNewWindowAction callbacks:
> 
> typedef void (*WKPageDecidePolicyForNavigationActionCallback)(WKPageRef
> page, WKFrameRef frame, WKFrameNavigationType navigationType,
> WKEventModifiers modifiers, WKEventMouseButton mouseButton, bool
> isUserInitiated, WKFrameRef originatingFrame, WKURLRequestRef request,
> WKFramePolicyListenerRef listener, WKTypeRef userData, const void*
> clientInfo);
> typedef void (*WKPageDecidePolicyForNewWindowActionCallback)(WKPageRef page,
> WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers
> modifiers, WKEventMouseButton mouseButton, bool isUserInitiated,
> WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef
> listener, WKTypeRef userData, const void* clientInfo);
> 
> This is needed for <rdar://problem/20139052>

I see that that has been resolved without relying on the new callback, so I think we are not going to make this change.