Bug 143958 – Context menu doesn't account for selection semantics

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The right-click context menu only considers the word directly under the mouse. Instead, we should use the Lookup module (like we do with immediate actions) so that we get a contextually-relevant selection.

[Brent Fulgham]

<rdar://problem/19735706>

[Brent Fulgham]

Created attachment 251247 [details]
Patch

[Build Bot]

Comment on attachment 251247 [details]
Patch

Attachment 251247 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4708163676798976

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 251249 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Brent Fulgham]

Uh oh! Looks like I introduced some crashes. Will fix.

[Build Bot]

Comment on attachment 251247 [details]
Patch

Attachment 251247 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4863398290391040

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 251253 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Brent Fulgham]

Committed r183077: <http://trac.webkit.org/changeset/183077>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 144021

[Brent Fulgham]

Created attachment 251345 [details]
Patch v2 (Test Fixes)

[Brent Fulgham]

Comment on attachment 251345 [details]
Patch v2 (Test Fixes)

Revised patch as follows:
1. Dictionary lookup was not honoring standard WebKit editing rules for handling hit tests at end-of-line, end-of-paragraph, etc.
2. The new dictionary lookup was not retaining trailing spaces when asked to by the system.
3. Rebaselined one test for the new dictionary-lookup behavior.

[Brent Fulgham]

Looks like I'll also need to rebaseline some tests based on the Mavericks bot output.

[Build Bot]

Comment on attachment 251345 [details]
Patch v2 (Test Fixes)

Attachment 251345 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6495054554202112

New failing tests:
editing/selection/select-from-textfield-outwards.html
editing/selection/doubleclick-beside-cr-span.html

[Build Bot]

Created attachment 251348 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 251345 [details]
Patch v2 (Test Fixes)

Attachment 251345 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6563398422626304

New failing tests:
editing/selection/select-from-textfield-outwards.html

[Build Bot]

Created attachment 251355 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Brent Fulgham]

Created attachment 251367 [details]
Patch (v3 Don't touch regular selection)

[Brent Fulgham]

Comment on attachment 251367 [details]
Patch (v3 Don't touch regular selection)

Revised the patch to only affect context menu operations. This corrected the five failing tests.

[Tim Horton]

Comment on attachment 251367 [details]
Patch (v3 Don't touch regular selection)

You could probably write a test.

[Brent Fulgham]

Committed r183138: <http://trac.webkit.org/changeset/183138>

[Brent Fulgham]

(In reply to comment #19)
> Comment on attachment 251367 [details]
> Patch (v3 Don't touch regular selection)
> 
> You could probably write a test.

Test added during landing! :-)