Bug 143938 – Make WTF Logging runtime switchable, starting with WebCore's Network channel

• Status: NEW
• Component: Web Template Framework

[Gavin Barraclough]

Currently WTF logging only works in debug builds; it would be useful if it could be enabled in release builds.

Logging should also support severity levels to enable different granularities (with the potential to vary default verbosity by system capabilities and build style).

Adding new logging macro to support level & moving channels incrementally, since some logging may be expensive even when disabled.

[Gavin Barraclough]

Created attachment 251137 [details]
Fix

[Gavin Barraclough]

With the attached patch, Network logging can be enabled in a release build using:

    defaults write com.apple.WebKit.Networking.Development WebCoreLogging 'Network'

[WebKit Commit Bot]

Attachment 251137 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/Logging.cpp:35:  JOIN_LOG_CHANNEL_WITH_PREFIX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/Logging.cpp:36:  JOIN_LOG_CHANNEL_WITH_PREFIX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Per conversation with Geoff, Geoff likes log level names "Always", "Customer", "Debug".

[Blaze Burg]

If you rebase this, I'll review it!

[Blaze Burg]

Comment on attachment 251137 [details]
Fix

Clearing r?, this patch is rotted.