Bug 143936 - Update RefPtr documentation and deprecation
Summary: Update RefPtr documentation and deprecation
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2015-04-19 11:25 PDT by Darin Adler
Modified: 2015-04-19 21:43 PDT (History)
5 users (show)

See Also:

Patch (33.54 KB, patch)
2015-04-19 11:27 PDT, Darin Adler
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-04-19 11:25:03 PDT
Update RefPtr documentation and deprecation
Comment 1 Darin Adler 2015-04-19 11:27:49 PDT
Created attachment 251120 [details]
Comment 2 Darin Adler 2015-04-19 11:29:48 PDT
This is actually just a start; I had a hard time figuring out what to say in the documentation.
Comment 3 Andreas Kling 2015-04-19 17:28:16 PDT
Comment on attachment 251120 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=251120&action=review

Thank you very much for these updates.

r=me with some minor glitches fixed.

> Websites/webkit.org/coding/RefPtr.html:115
> +<p>The title starts with a reference count of 1. The <span class="function">setTitle</span> function stores it in the data member,
> +and the reference count is increments to 1. Then the local variable <span class="variable">untitledTitle</span> goes out of
> +scope and the reference count is decremented back to 1.</p>

is increments to 1 -> is incremented to 2

> Websites/webkit.org/coding/RefPtr.html:249
> +examine or modify the refernece count.</p>

refernece -> reference

> Websites/webkit.org/coding/RefPtr.html:333
> +Not all getters need to take an rvalue reference.</li>

Not all getters -> Not all setters
Comment 4 Darin Adler 2015-04-19 21:43:49 PDT
Committed r183001: <http://trac.webkit.org/changeset/183001>