WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143933
[WK2] Have API::Array creation methods return Ref<>
https://bugs.webkit.org/show_bug.cgi?id=143933
Summary
[WK2] Have API::Array creation methods return Ref<>
Zan Dobersek
Reported
2015-04-19 00:40:05 PDT
[WK2] Have API::Array creation methods return Ref<>
Attachments
Patch
(58.89 KB, patch)
2015-04-19 00:48 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch for landing
(58.80 KB, patch)
2015-04-22 05:26 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2015-04-19 00:48:42 PDT
Created
attachment 251117
[details]
Patch
Darin Adler
Comment 2
2015-04-19 16:50:23 PDT
Comment on
attachment 251117
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=251117&action=review
> Source/WebKit2/Shared/API/APIArray.h:33 > +#include <wtf/Ref.h>
I think that <wtf/Forward.h> should suffice. We don’t really need to include Ref just to compile a function definition that returns a Ref<X>.
> Source/WebKit2/Shared/API/c/WKDictionary.cpp:62 > + Ref<API::Array> keys = toImpl(dictionaryRef)->keys(); > + return toAPI(&keys.leakRef());
I don’t think we need this local variable.
> Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm:78 > + Ref<API::Array> list = _list->backList(); > + return [wrapper(list.leakRef()) autorelease];
Doesn’t seem like we need the two lines here.
> Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm:84 > + Ref<API::Array> list = _list->forwardList(); > + return [wrapper(list.leakRef()) autorelease];
Doesn’t seem like we need the two lines here.
Zan Dobersek
Comment 3
2015-04-22 05:26:11 PDT
Created
attachment 251309
[details]
Patch for landing
Zan Dobersek
Comment 4
2015-04-22 08:29:24 PDT
Comment on
attachment 251309
[details]
Patch for landing Clearing flags on attachment: 251309 Committed
r183105
: <
http://trac.webkit.org/changeset/183105
>
Zan Dobersek
Comment 5
2015-04-22 08:29:31 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug