Bug 143933 – [WK2] Have API::Array creation methods return Ref<>

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[WK2] Have API::Array creation methods return Ref<>

[Zan Dobersek]

Created attachment 251117 [details]
Patch

[Darin Adler]

Comment on attachment 251117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251117&action=review

> Source/WebKit2/Shared/API/APIArray.h:33
> +#include <wtf/Ref.h>

I think that <wtf/Forward.h> should suffice. We don’t really need to include Ref just to compile a function definition that returns a Ref<X>.

> Source/WebKit2/Shared/API/c/WKDictionary.cpp:62
> +    Ref<API::Array> keys = toImpl(dictionaryRef)->keys();
> +    return toAPI(&keys.leakRef());

I don’t think we need this local variable.

> Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm:78
> +    Ref<API::Array> list = _list->backList();
> +    return [wrapper(list.leakRef()) autorelease];

Doesn’t seem like we need the two lines here.

> Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm:84
> +    Ref<API::Array> list = _list->forwardList();
> +    return [wrapper(list.leakRef()) autorelease];

Doesn’t seem like we need the two lines here.

[Zan Dobersek]

Created attachment 251309 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 251309 [details]
Patch for landing

Clearing flags on attachment: 251309

Committed r183105: <http://trac.webkit.org/changeset/183105>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.