Bug 143913 - [JSC] Add support for typed arrays to the Array profiling
Summary: [JSC] Add support for typed arrays to the Array profiling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-17 21:29 PDT by Benjamin Poulain
Modified: 2015-04-28 07:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.86 KB, patch)
2015-04-17 21:29 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (20.61 KB, patch)
2015-04-27 17:22 PDT, Benjamin Poulain 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-04-17 21:29:30 PDT 
Add support for typed arrays to the Array profiling
Comment 1 Benjamin Poulain 2015-04-17 21:29:55 PDT 
Created attachment 251082 [details]
Patch
Comment 2 Geoffrey Garen 2015-04-20 11:13:02 PDT 
Comment on attachment 251082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251082&action=review

Patch looks good to me. Is this ready to land?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:764
> -        
> +

Revert.
Comment 3 Benjamin Poulain 2015-04-27 17:22:51 PDT 
Created attachment 251794 [details]
Patch
Comment 4 Filip Pizlo 2015-04-27 20:19:05 PDT 
Comment on attachment 251794 [details]
Patch

Microbenchmark?  It would be great to have a microbenchmark in LayoutTests/js/regress/script-tests so that it'll run as part of JSRegress in run-jsc-benchmarks.
Comment 5 Benjamin Poulain 2015-04-27 21:17:32 PDT 
Committed r183450: <http://trac.webkit.org/changeset/183450>
Comment 6 Andy Estes 2015-04-28 07:45:09 PDT 
(In reply to comment #5)
> Committed r183450: <http://trac.webkit.org/changeset/183450>

The new test is missing an expected result, so I added the actual result from Yosemite in http://trac.webkit.org/changeset/183473. You might want to check if that's right.