Bug 143907 - [GTK] Miscellaneous changes for msys/mingw
Summary: [GTK] Miscellaneous changes for msys/mingw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 133028
  Show dependency treegraph
 
Reported: 2015-04-17 16:51 PDT by Milan Crha
Modified: 2015-05-19 01:00 PDT (History)
1 user (show)

See Also:


Attachments
proposed wk patch (3.07 KB, patch)
2015-04-17 16:54 PDT, Milan Crha
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Crha 2015-04-17 16:51:53 PDT
These are the last miscellaneous changes for webkit-2.4 branch at revision 182543 I use to be able to build it in msys/mingw.
Comment 1 Milan Crha 2015-04-17 16:54:09 PDT
Created attachment 251073 [details]
proposed wk patch
Comment 2 Carlos Garcia Campos 2015-05-19 00:31:10 PDT
Comment on attachment 251073 [details]
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251073&action=review

> Source/WTF/wtf/Platform.h:-615
> -#include <WTF/WTFHeaderDetection.h>
> -

What's wrong with this? I think I've already merged the other changes as part of other commits
Comment 3 Milan Crha 2015-05-19 00:42:21 PDT
The #include <WTF/WTFHeaderDetection.h> file doesn't exists with mingw/msys builds.
Comment 4 Carlos Garcia Campos 2015-05-19 00:57:52 PDT
Comment on attachment 251073 [details]
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251073&action=review

I'll merge only the autogenerated header part.

>> Source/WTF/wtf/Platform.h:-615
>> -#include <WTF/WTFHeaderDetection.h>
>> -
> 
> What's wrong with this? I think I've already merged the other changes as part of other commits

Ok, this is an autogenerated header, that we don't generate, so this is valid for 2.4 branch.
Comment 5 Carlos Garcia Campos 2015-05-19 01:00:45 PDT
Committed to 2.4 http://trac.webkit.org/changeset/184557