Bug 143905 - [Mac] Support -apple-system-* on OS X
Summary: [Mac] Support -apple-system-* on OS X
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-17 16:43 PDT by Myles C. Maxfield
Modified: 2015-04-17 16:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.26 KB, patch)
2015-04-17 16:44 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-04-17 16:43:33 PDT 
[Mac] Support -apple-system-* on OS X
Comment 1 Myles C. Maxfield 2015-04-17 16:44:51 PDT 
Created attachment 251070 [details]
Patch
Comment 2 Myles C. Maxfield 2015-04-17 16:45:55 PDT 
<rdar://problem/17080808>
Comment 3 WebKit Commit Bot 2015-04-17 16:46:47 PDT 
Attachment 251070 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Myles C. Maxfield 2015-04-17 16:48:09 PDT 
Comment on attachment 251070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251070&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

Need to port over iOS's tests.

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:41
> +#import "RenderThemeMac.h"

Layering violation!