Bug 143897 - prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks
Summary: prepare-ChangeLog sometimes includes unmodified functions on purely subtracti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 137889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-17 14:12 PDT by Matthew Hanson
Modified: 2016-07-21 17:27 PDT (History)
2 users (show)

See Also:

Attachments
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. (6.23 KB, patch)
2015-04-17 14:14 PDT, Matthew Hanson 		ddkilzer: review-
Details | Formatted Diff | Diff
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. (6.32 KB, patch)
2015-04-17 14:33 PDT, Matthew Hanson 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Hanson 2015-04-17 14:12:08 PDT 
When a Git combined diff hunk only includes one deletion, prepare-ChangeLog reports that the previous function/method has been modified.
Comment 1 Matthew Hanson 2015-04-17 14:14:27 PDT 
Created attachment 251045 [details]
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
Comment 2 Matthew Hanson 2015-04-17 14:16:02 PDT 
rdar://problem/20043230
Comment 3 Radar WebKit Bug Importer 2015-04-17 14:16:52 PDT 
<rdar://problem/20593033>
Comment 4 Matthew Hanson 2015-04-17 14:18:16 PDT 
<rdar://problem/20043230>
Comment 5 David Kilzer (:ddkilzer) 2015-04-17 14:28:39 PDT 
Comment on attachment 251045 [details]
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

View in context: https://bugs.webkit.org/attachment.cgi?id=251045&action=review

r- for commented out code.

> Tools/Scripts/prepare-ChangeLog:291
> +                # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) {

This shouldn't be commented out.  We don't check in commented out code.
Comment 6 Matthew Hanson 2015-04-17 14:33:00 PDT 
Created attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
Comment 7 David Kilzer (:ddkilzer) 2015-04-17 14:45:49 PDT 
Comment on attachment 251048 [details]
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.

r=me.  If this causes any regressions, we should create some Perl unit tests before re-landing.
Comment 8 Matthew Hanson 2015-04-20 15:08:34 PDT 
Committed https://trac.webkit.org/r183030.
Comment 9 Daniel Bates 2016-07-21 17:27:20 PDT 
*** Bug 137889 has been marked as a duplicate of this bug. ***