RESOLVED FIXED 143897
prepare-ChangeLog sometimes includes unmodified functions on purely subtractive hunks 
https://bugs.webkit.org/show_bug.cgi?id=143897
Summary prepare-ChangeLog sometimes includes unmodified functions on purely subtracti...
Matthew Hanson
Reported 2015-04-17 14:12:08 PDT
When a Git combined diff hunk only includes one deletion, prepare-ChangeLog reports that the previous function/method has been modified.
Attachments
prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. (6.23 KB, patch)
2015-04-17 14:14 PDT, Matthew Hanson 		ddkilzer: review-
DetailsFormatted DiffDiff
v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. (6.32 KB, patch)
2015-04-17 14:33 PDT, Matthew Hanson 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Hanson
Comment 1 2015-04-17 14:14:27 PDT
Created attachment 251045 [details] prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
Matthew Hanson
Comment 2 2015-04-17 14:16:02 PDT
rdar://problem/20043230
Radar WebKit Bug Importer
Comment 3 2015-04-17 14:16:52 PDT
<rdar://problem/20593033>
Matthew Hanson
Comment 4 2015-04-17 14:18:16 PDT
<rdar://problem/20043230>
David Kilzer (:ddkilzer)
Comment 5 2015-04-17 14:28:39 PDT
Comment on attachment 251045 [details] prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. View in context: https://bugs.webkit.org/attachment.cgi?id=251045&action=review r- for commented out code. > Tools/Scripts/prepare-ChangeLog:291 > + # if ($after_start >= 0 && $after_end >= 0 && $after_end >= $after_start) { This shouldn't be commented out. We don't check in commented out code.
Matthew Hanson
Comment 6 2015-04-17 14:33:00 PDT
Created attachment 251048 [details] v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
David Kilzer (:ddkilzer)
Comment 7 2015-04-17 14:45:49 PDT
Comment on attachment 251048 [details] v2: prepare-ChangeLog should ignore the preceeding function when processing the removal of a function. r=me. If this causes any regressions, we should create some Perl unit tests before re-landing.
Matthew Hanson
Comment 8 2015-04-20 15:08:34 PDT
Committed https://trac.webkit.org/r183030.
Daniel Bates
Comment 9 2016-07-21 17:27:20 PDT
*** Bug 137889 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.