Bug 143869 - [GStreamer] Silent WebAudio buffers support
Summary: [GStreamer] Silent WebAudio buffers support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on: 166922
Blocks:
  Show dependency tree / graph
 
Reported: 2015-04-17 02:45 PDT by Philippe Normand
Modified: 2018-01-31 08:17 PST (History)
7 users (show)

See Also:

Attachments
patch (1.84 KB, patch)
2015-04-17 02:52 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2018-01-31 07:46 PST, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-04-17 02:45:17 PDT 
Would be nice to set the GAP flag on silent buffers before pushing them to appsrc.
Comment 1 Philippe Normand 2015-04-17 02:52:57 PDT 
Created attachment 251012 [details]
patch
Comment 2 Philippe Normand 2015-04-17 03:45:05 PDT 
Committed r182947: <http://trac.webkit.org/changeset/182947>
Comment 3 WebKit Commit Bot 2017-01-11 01:05:30 PST 
Re-opened since this is blocked by bug 166922
Comment 4 Zan Dobersek 2017-08-21 04:01:11 PDT 
Problem that caused the roll-out was reported in bug #166884.
Comment 5 Philippe Normand 2017-09-04 02:34:21 PDT 
It would be interesting to debug this leak. Might be a bug in GStreamer's baseaudiosink.
Comment 6 Philippe Normand 2018-01-31 07:46:54 PST 
Created attachment 332761 [details]
Patch
Comment 7 Philippe Normand 2018-01-31 08:14:47 PST 
Committed r227902: <https://trac.webkit.org/changeset/227902>
Comment 8 Radar WebKit Bug Importer 2018-01-31 08:17:33 PST 
<rdar://problem/37070729>