Bug 143866 - [SOUP] Redirect to non HTTP destination is broken
Summary: [SOUP] Redirect to non HTTP destination is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on:
Blocks:
 
Reported: 2015-04-17 01:51 PDT by Carlos Garcia Campos
Modified: 2015-04-17 03:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2015-04-17 02:05 PDT, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-04-17 01:51:35 PDT 
This is because we are passing true unconditionally as isHTTPFamilyRequest parameter of createSoupRequestAndMessageForHandle in continueAfterWillSendRequest. I wrote a unit tests using a data URI to reproduce it:

$ bin/TestWebKitAPI/WebKit2Gtk/TestLoaderClient -p /webkit2/WebKitWebPage/redirect-to-data-uri
/webkit2/WebKitWebPage/redirect-to-data-uri: 
(WebKitWebProcess:19126): GLib-GObject-WARNING **: invalid cast from 'SoupRequestData' to 'SoupRequestHTTP'

(WebKitWebProcess:19126): libsoup-CRITICAL **: soup_request_http_get_message: assertion 'SOUP_IS_REQUEST_HTTP (http)' failed
**
ERROR:../../Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:292:void resourceGetDataCallback(GObject*, GAsyncResult*, gpointer): assertion failed: (data)
Abortado
Comment 1 Carlos Garcia Campos 2015-04-17 02:05:02 PDT 
Created attachment 251007 [details]
Patch
Comment 2 Sergio Villar Senin 2015-04-17 02:57:05 PDT 
Comment on attachment 251007 [details]
Patch

Nice catch!
Comment 3 Carlos Garcia Campos 2015-04-17 03:15:02 PDT 
Committed r182943: <http://trac.webkit.org/changeset/182943>