A odd crash

[Peng Xinchao]

I happend a odd crash  : the Backtrace is below :
WebKitWebProces: unhandled page fault (11) at 0x00000005, code 0x017

gdb) bt
#0 0x9c579d5c in ?? ()
#1 0x4701ea60 in JSC::Watchdog::Scope::~Scope() () from SymbolFiles/mtd_exe/Webkit/libjavascriptcoregtk-3.0.so.0
#2 0x46e7bd00 in JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) ()
from SymbolFiles/mtd_exe/Webkit/libjavascriptcoregtk-3.0.so.0
#3 0x46f6fbb4 in JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) () from SymbolFiles/mtd_exe/Webkit/libjavascriptcoregtk-3.0.so.0
#4 0x44a6cbc0 in WebCore::ScheduledAction::executeFunctionInContext(JSC::JSGlobalObject*, JSC::JSValue, WebCore::ScriptExecutionContext*) () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#5 0x44a6d320 in WebCore::ScheduledAction::execute(WebCore::Document*) () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#6 0x44a6d430 in WebCore::ScheduledAction::execute(WebCore::ScriptExecutionContext*) () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#7 0x44fbc534 in WebCore::DOMTimer::fired() () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#8 0x459e1c5c in WebCore::ThreadTimers::sharedTimerFiredInternal() () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#9 0x459e1cd8 in WebCore::ThreadTimers::sharedTimerFired() () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#10 0x45fe0cf0 in WebCore::timeout_cb(void*) () from SymbolFiles/mtd_exe/Webkit/libwebkit2gtk-3.0.so.0
#11 0x43f6e8d4 in ?? ()
#12 0x43f6e8d4 in ?? ()

Welcome to guess and analysis  the reason ! Thank you

[Mark Lam]

1. Do you have steps to reproduce this?
2. If so, what revision # are you building?

[Peng Xinchao]

JS source code is that :

setInterval(function() {
     .......
	var $osd = $('#osd');
	$osd.show();
     setTimeout(function() {
	 $osd.hide();
       }, 5000);
    ...
     },1000);
my webkit version is webkit-r150045. platform is arm-gtk .

[Mark Lam]

(In reply to comment #2)
> JS source code is that :
> 
> setInterval(function() {
>      .......
> 	var $osd = $('#osd');
> 	$osd.show();
>      setTimeout(function() {
> 	 $osd.hide();
>        }, 5000);
>     ...
>      },1000);
> my webkit version is webkit-r150045. platform is arm-gtk .

That is a very old version of the code.  Try updating to the tip of tree and see if the issue still manifests.

[Peng Xinchao]

After running these  JS Source code for  20 minute , Webprocess will coredump :
<script>   
 setInterval(function() {
			
	var d = new Date();
	var time = d.getHours().addNulls() + ":" + d.getMinutes().addNulls();			
	
	var $osd = $('#osd');
	$osd.show();
	$osd.find(".channel_time").text(time);
	setTimeout(function() {
		$osd.hide();
	}, 5000);
				
    }, 10000);
Number.prototype.addNulls = function () {
    if (this < 10) {
	return "0" + this;
	}
	return this.toString();
   }
</script>
I find two issue :
1: If disable DFG_JIT , the crash don't happen .
2. If "var time = d.getHours().addNulls() + ":" + d.getMinutes().addNulls();" is changed to "var time = d.getHours() + ":" + d.getMinutes();"
The crash don't happen
It looks like  process happen crash when addNulls  is called

[Peng Xinchao]

It look like  JSC DFG happen error when running  "return "0" + this;"
Because i found that the crash usually happen when "if (this < 10)".

[Peng Xinchao]

The issue 
void SpeculativeJIT::compile(Node* node)
{

}

[Peng Xinchao]

 
void SpeculativeJIT::compile(Node* node)
{
  .. .
    case ToThis: {
        ASSERT(node->child1().useKind() == UntypedUse);
....

}
In here ,  the value of "node->child1().useKind()" is UntypedUse .
I feel very strange 。
why ?

[Mark Lam]

(In reply to comment #7)
>  
> void SpeculativeJIT::compile(Node* node)
> {
>   .. .
>     case ToThis: {
>         ASSERT(node->child1().useKind() == UntypedUse);
> ....
> 
> }
> In here ,  the value of "node->child1().useKind()" is UntypedUse .
> I feel very strange 。
> why ?

Again, r150045 is very old (from 2 years ago).  There has been many enhancements and bug fixes since then.   Have you tried the latest revision (e.g. r182982) to see if the issue is still present?

[Peng Xinchao]

In the newest version (x86_gtk),The crash is still exist .

    case ToThis: {
        printf(" node->child1().useKind() =%d\n",node->child1().useKind());
        ASSERT(node->child1().useKind() == UntypedUse); ---> crash here

TestCase :
<html>
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
	<title>Tutorial Video Widget</title>
	<script>
function onLoad() {
		
			setInterval(function() {
				var d = new Date();
				var time = d.getHours().addNulls() + ":" + d.getMinutes().addNulls();			
				document.write("time="+time);
				document.write("<br>");
			}, 1000);

		}
Number.prototype.addNulls = function () {
			if (this < 100) {
				return "0" + this;
			}
			return this.toString();
		}
</script>
</head>
<body onload="onLoad();">

</body>
</html>

[Peng Xinchao]

Created attachment 254475 [details]
Patch

[Filip Pizlo]

Comment on attachment 254475 [details]
Patch

This is definitely not the right approach. You're just turning off ToThis in the DFG and creating a bunch of dead code. Note that the ToThis handling in DFG is designed to work with UntypedUse - so this patch doesn't make sense.