Bug 143847 – iOS Simulator.app no longer responds to AppleScript events after name change

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jake Nielsen]

Refer to rdar://problem/20530344

[Jake Nielsen]

Created attachment 250950 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 250950 [details]
Patch

Rejecting attachment 250950 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Jake Nielsen]

Created attachment 250952 [details]
Forgot to change a callsite.

[Simon Fraser (smfr)]

Comment on attachment 250952 [details]
Forgot to change a callsite.

View in context: https://bugs.webkit.org/attachment.cgi?id=250952&action=review

> Tools/ChangeLog:3
> +        iOS Simulator.app no longer responds to AppleScript events after name changed to Simulator.app.

Maybe change this.

[WebKit Commit Bot]

Comment on attachment 250952 [details]
Forgot to change a callsite.

Rejecting attachment 250952 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Jake Nielsen]

Created attachment 250956 [details]
Addresses comment.

[Daniel Bates]

Comment on attachment 250956 [details]
Addresses comment.

View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review

> Tools/ChangeLog:3
> +        Changes method of quitting iphone simulator to be more correct.

"iphone simulator" => iOS Simulator

> Tools/ChangeLog:7
> +        Fixes by addressing the app by ID rather than by name.

This is OK as-is. The bug description should come after the Reviewed By line. An example ChangeLog entry can be seen at <http://www.webkit.org/coding/contributing.html#changelogs>.

[Daniel Bates]

Comment on attachment 250956 [details]
Addresses comment.

View in context: https://bugs.webkit.org/attachment.cgi?id=250956&action=review

>> Tools/ChangeLog:3
>> +        Changes method of quitting iphone simulator to be more correct.
> 
> "iphone simulator" => iOS Simulator

This line should be the bug title. This reads like it should be part of the description.

[Jake Nielsen]

Created attachment 250967 [details]
Addresses Further Comments

[WebKit Commit Bot]

Comment on attachment 250967 [details]
Addresses Further Comments

Clearing flags on attachment: 250967

Committed r182937: <http://trac.webkit.org/changeset/182937>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.