It's not clear that WEBKIT_OPTION_DEFINE defines a private option or that WEBKIT_OPTION_DEFAULT_PORT_VALUE makes the option public. This was probably a mistake: let's require the user to choose PUBLIC or PRIVATE when defining or overriding the option. This also removes the short-lived WEBKIT_OPTION_DEFINE_PUBLIC and WEBKIT_OPTION_PRIVATE_PORT_VALUE macros.
Created attachment 250929 [details] Patch
Warning for Alex Christensen: this patch hides all your options (so they are not shown with 'cmake -L' except when -A is also passed, and so that they are not printed when running cmake). I figure that is probably what you want, so you can choose a small subset of them to make public later rather than choosing a large subset to make private. (The idea is that you only make the option public if you actually support both building with it on and building with it off.) Let me know if you want these to be public instead. EFL and GTK options all remain public in this patch, so as not to change the current behavior. For GTK we will make most of these private in bug #143558.
(In reply to comment #2) Thanks for the warning, but this is not a problem right now. We can publicize options later once it actually works on Mac and Windows and has more than just one user.
Comment on attachment 250929 [details] Patch It seems there is no critical issue for EFL side.
Comment on attachment 250929 [details] Patch Rejecting attachment 250929 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 250929, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e Source/cmake/OptionsMac.cmake patching file Source/cmake/OptionsWindows.cmake patching file Source/cmake/WebKitFeatures.cmake Hunk #2 FAILED at 20. Hunk #3 succeeded at 216 (offset 1 line). 1 out of 3 hunks FAILED -- saving rejects to file Source/cmake/WebKitFeatures.cmake.rej patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6076748026347520
Feel free to update and land. I'm not surprised something changed underneath you.
Created attachment 251316 [details] Patch
Comment on attachment 251316 [details] Patch Clearing flags on attachment: 251316 Committed r183104: <http://trac.webkit.org/changeset/183104>
All reviewed patches have been landed. Closing bug.