Bug 143827 - [GStreamer] improve video rendering stats
Summary: [GStreamer] improve video rendering stats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-04-16 06:14 PDT by Philippe Normand
Modified: 2020-01-14 06:53 PST (History)
14 users (show)

See Also:

Attachments
Patch (9.98 KB, patch)
2020-01-14 01:45 PST, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-04-16 06:14:41 PDT 
Since we know exactly which samples are rendered by the player we could easily gather statistics about dropped frames and rendered frames. Right now we depend on the fpsdisplaysink for that...

Instead we could:

1) before replacing the sample stored in player, check if it was rendered by fetching some bool variable from its qdata
2) when rendering set the bool variable in qdata to TRUE
Comment 1 Philippe Normand 2020-01-14 01:45:44 PST 
Created attachment 387635 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-01-14 03:39:59 PST 
Comment on attachment 387635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387635&action=review

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:314
> +        break;

We can maybe ASSERT_NOT_REACHED here.
Comment 3 Philippe Normand 2020-01-14 06:52:41 PST 
Committed r254507: <https://trac.webkit.org/changeset/254507>
Comment 4 Radar WebKit Bug Importer 2020-01-14 06:53:15 PST 
<rdar://problem/58566720>