Bug 143823 - [EFL] Remove an unnecessary workaround from jhbuildrc
Summary: [EFL] Remove an unnecessary workaround from jhbuildrc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 05:32 PDT by Csaba Osztrogonác
Modified: 2015-04-16 06:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2015-04-16 05:33 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-04-16 05:32:30 PDT 
It was added long long time ago:
# FIXME: The depedencies of EFL 1.9 can not be updated unless MAKEFLAGS is set to '-j1'.
os.environ['MAKEFLAGS'] = '-j1'

The problem was that we used setting MAKEFLAGS=-j30 for icecc setup 
previously and make install of EFL can't handle parallel installing.

But building with icecc properly is to use NUMBER_OF_PROCESSORS
environment variable, which is passed to make by jhbuild, but
not for make install commands, because make install shouldn't
be parallelized.

So the solution is that folks don't use MAKEFLAGS to set -jXXX
and we won't need this hack anymore.
Comment 1 Csaba Osztrogonác 2015-04-16 05:33:31 PDT 
Created attachment 250915 [details]
Patch
Comment 2 WebKit Commit Bot 2015-04-16 06:28:34 PDT 
Comment on attachment 250915 [details]
Patch

Clearing flags on attachment: 250915

Committed r182883: <http://trac.webkit.org/changeset/182883>
Comment 3 WebKit Commit Bot 2015-04-16 06:28:38 PDT 
All reviewed patches have been landed.  Closing bug.