Bug 143819 - [GTK] Run forwarding headers generator unconditionally
Summary: [GTK] Run forwarding headers generator unconditionally
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-16 03:04 PDT by Csaba Osztrogonác
Modified: 2015-04-17 04:19 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2015-04-16 03:17 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-04-16 03:04:42 PDT 
bug137394 made it run depends on source code changes,
but renaming headers caused incremental build issues.

The runtime is quite short, approximately only 1 second,
so let's run it unconditionally again.

I already have a patch for it, I run the final test now
and will upload if everything is good.
Comment 1 Csaba Osztrogonác 2015-04-16 03:17:59 PDT 
Created attachment 250909 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-04-16 04:26:45 PDT 
Comment on attachment 250909 [details]
Patch

Thanks!
Comment 3 Csaba Osztrogonác 2015-04-16 04:47:33 PDT 
Comment on attachment 250909 [details]
Patch

Clearing flags on attachment: 250909

Committed r182882: <http://trac.webkit.org/changeset/182882>
Comment 4 Csaba Osztrogonác 2015-04-16 04:47:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2015-04-17 03:21:13 PDT 
and a speculative fix landed in http://trac.webkit.org/changeset/182945
Comment 6 Csaba Osztrogonác 2015-04-17 04:19:50 PDT 
I managed to reproduce the failure (with adding a long sleep into the
WK2's fw header generator rule). We really need the dependency, because
TestWebKitAPI contains zillion <WebKit/foo.h> Mac style framework include.
I added it back in http://trac.webkit.org/changeset/182948

EFL didn't have this problem, because it generates fw-ing headers
for WebKit2 too in TestWebKitAPI. It's so ugly, EFL should use the
same solution, I'm going to change it.