Bug 143813 – Web Inspector: Give DOM Nodes a Context Menu to Log Element to the console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Give DOM Nodes a Context Menu to Log Element to the console.

Anywhere we show a DOMTreeOutline we should be able to log to the console. This will give a $n value, so the $1-$9 case is conveniently replaceable by this.

[Radar WebKit Bug Importer]

<rdar://problem/20565622>

[Joseph Pecoraro]

Created attachment 250895 [details]
[PATCH] Proposed Fix

[Brian Burg]

Comment on attachment 250895 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review

r=me

Nice! Great to see a simple added use case to the console API. This change will be helpful reference.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:59
> +    this._domTreeOutline = new WebInspector.DOMTreeOutline(true, true, true);

In a separate patch, we should convert these boolean arguments into setters. There's no reason they need to be constructor arguments.

[Timothy Hatcher]

Comment on attachment 250895 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=250895&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:496
> +                var text = WebInspector.UIString("Selected Element");

The more we do this the more I think the text needs a special formatting. Italics? Tokenized?

[Joseph Pecoraro]

http://trac.webkit.org/changeset/182902