Bug 143805 – Make WKWebsiteDataStore public

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Make WKWebsiteDataStore public

[Anders Carlsson]

Created attachment 250877 [details]
Patch

[WebKit Commit Bot]

Attachment 250877 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:210:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 250877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250877&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:294
> +    webPageConfiguration.websiteDataStore = &((WKWebsiteDataStore *)[_configuration _websiteDataStore])->_websiteDataStore->websiteDataStore();

Do we need this already?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.h:31
> +

Need WK_ASSUME_NONNULL_BEGIN/END around the rest of this header.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.h:36
> ++ (instancetype)defaultDataStore;

The return type here should be WKWebsiteDataStore *, not instancetype.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:32
> +#import "WKNSArray.h"

Doesn’t this one import APIArray.h?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:37
> ++ (instancetype)defaultDataStore

Fix the return type.

[Anders Carlsson]

Created attachment 250882 [details]
Patch

[WebKit Commit Bot]

Attachment 250882 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:210:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 250882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250882&action=review

Something is off with the whitespace but I can’t quite put my finger on it.

> Source/WebKit2/ChangeLog:9
> +        @interface and @implementation that just derives from WKWebsiteDataStore.

There’s a little more to _WKWebsiteDataStore in this version of the patch.

> Source/WebKit2/ChangeLog:18
> +        * UIProcess/API/Cocoa/WKWebsiteDataStore.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.h.

You should mention the other changes: stricter return types and unavailability of -init.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:294
> +    webPageConfiguration.websiteDataStore = &((WKWebsiteDataStore *)[_configuration _websiteDataStore])->_websiteDataStore->websiteDataStore();

This remains a mystery to me.

> Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:27
> +#include "config.h"
> +#include "_WKWebsiteDataStore.h"

#import

[Anders Carlsson]

Committed r182873: <http://trac.webkit.org/changeset/182873>