Bug 143795 - Sites with both width=device-width and height=device-height load zoomed out
Summary: Sites with both width=device-width and height=device-height load zoomed out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL: InRadar
Keywords:
Depends on:
Blocks: 156504
  Show dependency tree / graph
 
Reported: 2015-04-15 13:56 PDT by Tim Horton
Modified: 2016-04-12 09:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2015-04-15 13:56 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2015-04-15 17:05 PDT, Tim Horton 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-04-15 13:56:32 PDT 
Sites with both width=device-width and height=device-height load zoomed out
Comment 1 Tim Horton 2015-04-15 13:56:50 PDT 
Created attachment 250855 [details]
Patch
Comment 2 Benjamin Poulain 2015-04-15 15:36:41 PDT 
Comment on attachment 250855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250855&action=review

> Source/WebCore/page/ViewportConfiguration.cpp:122
> +    if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth)

We should be even more aggressive.

Where are the tests? ;)
Comment 3 Tim Horton 2015-04-15 17:05:14 PDT 
Created attachment 250883 [details]
Patch
Comment 4 Tim Horton 2015-04-16 13:38:11 PDT 
(In reply to comment #2)
> Comment on attachment 250855 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250855&action=review
> 
> > Source/WebCore/page/ViewportConfiguration.cpp:122
> > +    if (m_viewportArguments.height == ViewportArguments::ValueDeviceHeight && m_viewportArguments.width != ViewportArguments::ValueDeviceWidth)
> 
> We should be even more aggressive.

OK! Done.

> Where are the tests? ;)

Hopefully we can have tests soon, after WKTR uses WKWebView always.
Comment 5 Tim Horton 2015-04-16 14:25:42 PDT 
http://trac.webkit.org/changeset/182910
Comment 6 Daniel Bates 2015-04-16 14:28:18 PDT 
<rdar://problem/20369671>