Bug 143792 - Harden DFGForAllKills
Summary: Harden DFGForAllKills
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 143734
  Show dependency tree / graph
 
Reported: 2015-04-15 12:10 PDT by Filip Pizlo
Modified: 2015-04-15 13:34 PDT (History)
11 users (show)

See Also:

Attachments
the patch (6.77 KB, patch)
2015-04-15 12:15 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-04-15 12:10:19 PDT 
Currently it appears to have issues with:

- Bytecode instructions that don't have an origin in DFG IR because the operations were killed off.

- MovHint doing a kill because the local is always live.
Comment 1 Filip Pizlo 2015-04-15 12:15:36 PDT 
Created attachment 250833 [details]
the patch
Comment 2 Geoffrey Garen 2015-04-15 13:09:50 PDT 
Comment on attachment 250833 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-04-15 13:34:05 PDT 
Landed in http://trac.webkit.org/changeset/182857