Bug 143787 - Clean up: Have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath instead of a pointer
Summary: Clean up: Have SVGTextLayoutEngine::beginTextPathLayout() take a reference to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-15 11:04 PDT by Daniel Bates
Modified: 2015-04-15 15:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2015-04-15 11:14 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2015-04-15 11:04:34 PDT 
Currently SVGTextLayoutEngine::beginTextPathLayout() takes a pointer to a RenderObject and run-time asserts that its non-null and assumes that it can be safely downcast to a reference to RenderSVGTextPath object. Instead we should have SVGTextLayoutEngine::beginTextPathLayout() take a reference to a RenderSVGTextPath to better catch at compile time and document the preconditions of this function.
Comment 1 Daniel Bates 2015-04-15 11:14:31 PDT 
Created attachment 250826 [details]
Patch
Comment 2 Andreas Kling 2015-04-15 15:16:24 PDT 
Comment on attachment 250826 [details]
Patch

r=me
Comment 3 Daniel Bates 2015-04-15 15:36:42 PDT 
Comment on attachment 250826 [details]
Patch

Clearing flags on attachment: 250826

Committed r182864: <http://trac.webkit.org/changeset/182864>
Comment 4 Daniel Bates 2015-04-15 15:36:48 PDT 
All reviewed patches have been landed.  Closing bug.